Dotts/Papay-Shooter
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: rename shadowed 'visible' param, prefix unused 'impulse' with underscore

Browse Source
This commit is contained in:
Hermes
2026-06-22 20:34:02 -04:00
parent a1f48d9ef0
commit ade3d54d20
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
characters/humanoid_model.gd
+2 -2
View File
@@ -192,10 +192,10 @@ func apply_skin(skin: PlayerSkin) -> void:
skin_model = null skin_model = null
_apply_color(skin.color_tint) _apply_color(skin.color_tint)
func _set_procedural_visible(visible: bool) -> void: func _set_procedural_visible(is_visible: bool) -> void:
for part in [torso, head, upper_arm_l, lower_arm_l, upper_arm_r, lower_arm_r, thigh_l, calf_l, thigh_r, calf_r]: for part in [torso, head, upper_arm_l, lower_arm_l, upper_arm_r, lower_arm_r, thigh_l, calf_l, thigh_r, calf_r]:
if part: if part:
part.visible = visible part.visible = is_visible
func _apply_color(col: Color) -> void: func _apply_color(col: Color) -> void:
var mat = StandardMaterial3D.new() var mat = StandardMaterial3D.new()
entities/target_dummy.gd
+1 -1
View File
@@ -33,7 +33,7 @@ func _ready() -> void:
dps_label.modulate = Color(1, 0.8, 0) dps_label.modulate = Color(1, 0.8, 0)
add_child(dps_label) add_child(dps_label)
func take_damage(amount: float, hit_position: Vector3, source: Node = null, impulse: Vector3 = Vector3.ZERO) -> void: func take_damage(amount: float, hit_position: Vector3, source: Node = null, _impulse: Vector3 = Vector3.ZERO) -> void:
var now = Time.get_ticks_msec() / 1000.0 var now = Time.get_ticks_msec() / 1000.0
damage_history.append({"time": now, "amount": amount}) damage_history.append({"time": now, "amount": amount})